Re: [PATCH 1/2] hung_task: Consolidate hung task warning into an atomic log block
From: Aaron Tomlin
Date: Tue Dec 09 2025 - 17:14:55 EST
On Tue, Dec 09, 2025 at 03:56:58PM +0900, Greg KH wrote:
> > "%s\n" forces an unconditional newline, causing a spurious blank line when
> > the flag isn't set, right?
>
> The first \n should not be there, this should be all one line.
Hi Greg,
I agree. This will be resolved in a subsequent patch.
> If you have multiple lines wanting to be printed, use multiple pr_err()
> calls.
Unfortunately, sequential pr_err() calls risk having their lines separated
by other log messages, rendering the warning incoherent. The single-call
implementation is necessary to ensure the entire message is atomically
written.
Kind regards,
--
Aaron Tomlin
Attachment:
signature.asc
Description: PGP signature