Re: [PATCH v6 4/8] drm/panel: sw43408: Add enable/disable and reset functions
From: David Heidelberg
Date: Tue Dec 09 2025 - 17:51:25 EST
On 09/12/2025 23:37, Dmitry Baryshkov wrote:
On Mon, Dec 08, 2025 at 10:41:57AM +0100, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <david@xxxxxxx>
Introduce enable(), disable() and reset() functions.
The enable() and disable() callbacks keep the symmetry in the commands
sent to the panel and also make a clearer distinction between panel
initialization and configuration.
It's not just it. There is a difference between commands being sent in
en/disable and prepare/unprepare.
Thanks, I didn't know. Is there good rule how to distinguish, which command should go where?
Splitting reset() from prepare() follows clean coding practices and lets
us potentially make reset optional in the future for flicker-less
takeover from a bootloader or framebuffer driver where the panel is
already configured.
Signed-off-by: David Heidelberg <david@xxxxxxx>
---
drivers/gpu/drm/panel/panel-lg-sw43408.c | 47 ++++++++++++++++++++++++--------
1 file changed, 35 insertions(+), 12 deletions(-)
--
David Heidelberg