Re: [PATCH v8 3/5] media: iris: Add support for AV1 format in iris decoder

[Deepa Guthyappa Madivalara]

On 12/8/2025 2:51 AM, Wangao Wang wrote:
> On 2025/12/3 7:03, Deepa Guthyappa Madivalara wrote:
> > +static struct platform_inst_fw_cap inst_fw_cap_sm8550_dec[] = {
> >       {
> >           .cap_id = PROFILE_H264,
> >           .min = V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE,
> > @@ -759,6 +778,8 @@ const struct iris_platform_data sm8550_data = {
> >       .dma_mask = 0xe0000000 - 1,
> >       .fwname = "qcom/vpu/vpu30_p4.mbn",
> >       .pas_id = IRIS_PAS_ID,
> > +    .inst_iris_fmts = platform_fmts_sm8550_dec,
> > +    .inst_iris_fmts_size = ARRAY_SIZE(platform_fmts_sm8550_dec),
> >       .inst_caps = &platform_inst_cap_sm8550,
> >       .inst_fw_caps_dec = inst_fw_cap_sm8550_dec,
> >       .inst_fw_caps_dec_size = ARRAY_SIZE(inst_fw_cap_sm8550_dec),
> > @@ -851,6 +872,8 @@ const struct iris_platform_data sm8650_data = {
> >       .dma_mask = 0xe0000000 - 1,
> >       .fwname = "qcom/vpu/vpu33_p4.mbn",
> >       .pas_id = IRIS_PAS_ID,
> > +    .inst_iris_fmts = platform_fmts_sm8550_dec,
> > +    .inst_iris_fmts_size = ARRAY_SIZE(platform_fmts_sm8550_dec),
> >       .inst_caps = &platform_inst_cap_sm8550,
> >       .inst_fw_caps_dec = inst_fw_cap_sm8550_dec,
> >       .inst_fw_caps_dec_size = ARRAY_SIZE(inst_fw_cap_sm8550_dec),
>
> I noticed that you didn’t add inst_iris_fmts to the platform data for 
> qcs8300 and sm8750, which will prevent the decoders on these platforms 
> from running.
Done. Thanks for the comment.