Re: [PATCH v5] tty: tty_port: add workqueue to flip tty buffer

From: Xin Zhao
Date: Tue Dec 09 2025 - 21:09:07 EST


Dear Jiri,

On Mon, 8 Dec 2025 08:26:51 +0100 Jiri Slaby <jirislaby@xxxxxxxxxx> wrote:

> > + if (!(driver->flags & TTY_DRIVER_CUSTOM_WORKQUEUE)) {
> > + driver->flip_wq = alloc_workqueue("%s-flip-wq",
> > + WQ_UNBOUND | WQ_SYSFS,
> > + 0, driver->name);
>
> Do you have to wrap the line here?

It looks like I need to add line breaks:

./scripts/checkpatch.pl 0001-tty-tty_port-add-workqueue-to-flip-tty-buffer.patch

WARNING: line length of 104 exceeds 100 columns
#227: FILE: drivers/tty/tty_io.c:3450:
+ driver->flip_wq = alloc_workqueue("%s-flip-wq", WQ_UNBOUND | WQ_SYSFS, 0, driver->name);

--
Xin Zhao