RE: [PATCH] smpboot: Add NULL check before kthread_unpark()

From: Kumar, Kaushlendra

Date: Wed Dec 10 2025 - 03:22:56 EST


On Mon, Nov 24 2025, Thomas Gleixner wrote:
> On Mon, Nov 24 2025 at 10:41, Kaushlendra Kumar wrote:
>> Add NULL check for tsk before calling kthread_unpark() in
>> smpboot_unpark_thread() to prevent potential null pointer dereference.
>
> How is that ever going to be NULL?
Thanks for the review.
Here I was only concerned about edge cases during CPU hotplug state transitions.

Could you help clarify: are there any scenarios during the CPU hotplug state
transition where this function might be called without a valid task, or is the
current flow guaranteed to always have tsk initialized at this point?

If the existing code ensure tsk is always valid here, will drop this patch.



-Kaushlendra