Re: [PATCH] net: can: fix build dependency

From: Arnd Bergmann
Date: Wed Dec 10 2025 - 04:10:57 EST


On Wed, Dec 10, 2025, at 09:16, Marc Kleine-Budde wrote:
> On 05.12.2025 00:30:14, Vincent Mailhol wrote:

>> > can-dev.> -if CAN_DEV
>> > +if CAN_DEV && CAN
>> ^^^^^^
>> Is this needed? CAN_DEV depends on CAN, so the condition
>>
>> CAN_DEV && !CAN
>>
>> should not be reachable.
>
> Removed the '&& CAN' while applying the patch.

Sorry I forgot to reply here: the '&& CAN' is absolutely
required here, otherwise you can configure CAN device drivers
as built-in with CAN_DEV=y CAN=m, and that results in a
link failure.

Arnd