[PATCH v3] spi: spi-fsl-lpspi: convert min_t() to simple min()
From: Carlos Song
Date: Wed Dec 10 2025 - 05:50:40 EST
Current min() has supported comparison by normal integer promotion rules,
so explicit type casts or min_t() are not needed.
Signed-off-by: Carlos Song <carlos.song@xxxxxxx>
Reviewed-by: David Laight <david.laight.linux@xxxxxxxxx>
---
Change since v2:
* remove 'Fixes' tag according to David's comment
* add review-by tag.
Change since v1:
* remove unused comment according to David's comment
* improve commit log according to Frank's comment
---
drivers/spi/spi-fsl-lpspi.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
index 065456aba2ae..8f45ead23836 100644
--- a/drivers/spi/spi-fsl-lpspi.c
+++ b/drivers/spi/spi-fsl-lpspi.c
@@ -486,15 +486,7 @@ static int fsl_lpspi_setup_transfer(struct spi_controller *controller,
fsl_lpspi->tx = fsl_lpspi_buf_tx_u32;
}
- /*
- * t->len is 'unsigned' and txfifosize and watermrk is 'u8', force
- * type cast is inevitable. When len > 255, len will be truncated in min_t(),
- * it caused wrong watermark set. 'unsigned int' is as the designated type
- * for min_t() to avoid truncation.
- */
- fsl_lpspi->watermark = min_t(unsigned int,
- fsl_lpspi->txfifosize,
- t->len);
+ fsl_lpspi->watermark = min(fsl_lpspi->txfifosize, t->len);
if (fsl_lpspi_can_dma(controller, spi, t))
fsl_lpspi->usedma = true;
--
2.34.1