Re: [PATCH] MIPS: Alchemy: Remove bogus static/inline specifiers

[Thomas Bogendoerfer]

On Mon, Dec 08, 2025 at 10:16:29AM -0800, Florian Fainelli wrote:
> On 10/29/25 08:03, Thierry Reding wrote:
> > From: Thierry Reding <treding@xxxxxxxxxx>
> > 
> > The recent io_remap_pfn_range() rework applied the static and inline
> > specifiers to the implementation of io_remap_pfn_range_pfn() on MIPS
> > Alchemy, mirroring the same change on other platforms. However, this
> > function is defined in a source file and that definition causes a
> > conflict with its declaration. Fix this by dropping the specifiers.
> > 
> > Fixes: 8efb51ad1b05 ("mm: abstract io_remap_pfn_range() based on PFN")
> > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> 
> Tested-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> 
> Thanks!
> 
> Thomas, can you pick this up so we have working alchemy builds again?

well, I've acked the patch for inclusion in the tree where the broken
commit was applied, but I could take it.

I'll correct the Fixes tag to

Fixes: c707a68f9468 ("mm: abstract io_remap_pfn_range() based on PFN")

when applying.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]