Re: [PATCH v4 4/6] media: iris: Move vpu register defines to common header file

From: Bryan O'Donoghue
Date: Wed Dec 10 2025 - 16:26:53 EST


On 10/12/2025 15:47, Vikash Garodia wrote:

On 12/10/2025 8:33 PM, Dmitry Baryshkov wrote:
On Wed, Dec 10, 2025 at 06:06:02PM +0530, Vikash Garodia wrote:
Some of vpu4 register defines are common with vpu3x. Move those into the
common register defines header. This is done to reuse the defines for
vpu4 in subsequent patch which enables the power sequence for vpu4.

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
Co-developed-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
Signed-off-by: Vishnu Reddy <busanna.reddy@xxxxxxxxxxxxxxxx>
Signed-off-by: Vikash Garodia <vikash.garodia@xxxxxxxxxxxxxxxx>

You have missed my CdB / SoB tags here.

Sure thing.

Bryan,

let me know if you can add while raising the PR, or else i can send a new revision.

Regards,
Vikash


Its fine b4 trailers --update will pull this.

---
bod