Re: [PATCH] drm: Remove remaining DRM_KMS_DMA_HELPER users

From: Randy Dunlap
Date: Wed Dec 10 2025 - 18:13:47 EST




On 12/10/25 2:23 PM, Paul Kocialkowski wrote:
> The DRM_KMS_CMA_HELPER config option was removed in commit 09717af7d13d
> ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") but two drivers were
> later merged with the option still selected.
>
> The dangling option was later renamed to DRM_KMS_DMA_HELPER with commit
> 6bcfe8eaeef0 ("drm/fb: rename FB CMA helpers to FB DMA helpers").
>
> Remove the entries in the two drivers, which already select
> DRM_GEM_DMA_HELPER (that was previously selected via DRM_KMS_CMA_HELPER).
>
> Signed-off-by: Paul Kocialkowski <paulk@xxxxxxxxxxx>

Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
> drivers/gpu/drm/adp/Kconfig | 1 -
> drivers/gpu/drm/logicvc/Kconfig | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/adp/Kconfig b/drivers/gpu/drm/adp/Kconfig
> index 9fcc27eb200d..acfa21ee06d2 100644
> --- a/drivers/gpu/drm/adp/Kconfig
> +++ b/drivers/gpu/drm/adp/Kconfig
> @@ -6,7 +6,6 @@ config DRM_ADP
> select DRM_KMS_HELPER
> select DRM_BRIDGE_CONNECTOR
> select DRM_DISPLAY_HELPER
> - select DRM_KMS_DMA_HELPER
> select DRM_GEM_DMA_HELPER
> select DRM_PANEL_BRIDGE
> select VIDEOMODE_HELPERS
> diff --git a/drivers/gpu/drm/logicvc/Kconfig b/drivers/gpu/drm/logicvc/Kconfig
> index 579a358ed5cf..11aae1626199 100644
> --- a/drivers/gpu/drm/logicvc/Kconfig
> +++ b/drivers/gpu/drm/logicvc/Kconfig
> @@ -4,7 +4,6 @@ config DRM_LOGICVC
> depends on OF || COMPILE_TEST
> select DRM_CLIENT_SELECTION
> select DRM_KMS_HELPER
> - select DRM_KMS_DMA_HELPER
> select DRM_GEM_DMA_HELPER
> select REGMAP
> select REGMAP_MMIO

--
~Randy