fs/namespace.c:2867 may_change_propagation() warn: inconsistent indenting
From: kernel test robot
Date: Wed Dec 10 2025 - 19:56:35 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0048fbb4011ec55c32d3148b2cda56433f273375
commit: cffd0441872e7f6b1fce5e78fb1c99187a291330 use uniform permission checks for all mount propagation changes
date: 4 months ago
config: x86_64-randconfig-161-20251210 (https://download.01.org/0day-ci/archive/20251211/202512110853.cxVpnF0V-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.4.0-5) 12.4.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512110853.cxVpnF0V-lkp@xxxxxxxxx/
New smatch warnings:
fs/namespace.c:2867 may_change_propagation() warn: inconsistent indenting
Old smatch warnings:
fs/namespace.c:3867 finish_automount() warn: inconsistent returns '&dentry->d_inode->i_rwsem'.
vim +2867 fs/namespace.c
2861
2862 static int may_change_propagation(const struct mount *m)
2863 {
2864 struct mnt_namespace *ns = m->mnt_ns;
2865
2866 // it must be mounted in some namespace
> 2867 if (IS_ERR_OR_NULL(ns)) // is_mounted()
2868 return -EINVAL;
2869 // and the caller must be admin in userns of that namespace
2870 if (!ns_capable(ns->user_ns, CAP_SYS_ADMIN))
2871 return -EPERM;
2872 return 0;
2873 }
2874
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki