Re: [PATCH] ksmbd: remove redundant DACL check in smb_check_perm_dacl
From: Namjae Jeon
Date: Wed Dec 10 2025 - 20:39:05 EST
On Wed, Dec 10, 2025 at 10:52 PM Alexey Velichayshiy
<a.velichayshiy@xxxxxxxxx> wrote:
>
> A zero value of pdacl->num_aces is already handled at the start of
> smb_check_perm_dacl() so the second check is useless.
>
> Drop the unreachable code block, no functional impact intended.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Alexey Velichayshiy <a.velichayshiy@xxxxxxxxx>
Applied it to #ksmbd-for-next-next.
Thanks!