Re: [PATCH v3] mm/damon/sysfs-schemes: Remove outdated TODO in target_nid_store()
From: SeongJae Park
Date: Thu Dec 11 2025 - 01:05:56 EST
On Thu, 11 Dec 2025 03:27:22 +0000 Swaraj Gaikwad <swarajgaikwad1925@xxxxxxxxx> wrote:
> The TODO comment in target_nid_store() suggested adding range validation
> for target_nid. As discussed in [1], the current behavior of accepting
> any integer value is intentional. DAMON sysfs aims to remain flexible,
> including supporting users who prepare node IDs before future NUMA hotplug
> events.
>
> Because this behavior matches the broader design philosophy of the DAMON
> sysfs interface, the TODO comment is now misleading. This patch removes the
> comment without introducing any behavioral change.
>
> No functional changes.
>
> [1] https://lore.kernel.org/lkml/20251210150930.57679-1-sj@xxxxxxxxxx/
>
> Suggested-by: SeongJae Park <sj@xxxxxxxxxx>
> Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>
> Signed-off-by: Swaraj Gaikwad <swarajgaikwad1925@xxxxxxxxx>
Looks all good, thank you for doing this, Swaraj!
Thanks,
SJ
[...]