Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf()

[Andrew Morton]

On Sun, 07 Dec 2025 03:53:18 +0000 Brendan Jackman <jackmanb@xxxxxxxxxx> wrote:

> Recent additions to this function cause GCC 14.3.0 to get excited and
> suggest a missing attribute:
> 
> lib/bug.c: In function ‘__warn_printf’:
> lib/bug.c:187:25: error: function ‘__warn_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>   187 |                         vprintk(fmt, *args);
>       |                         ^~~~~~~
> 
> Disable the diagnostic locally, following the pattern used for stuff
> like va_format().
> 

Question please.  Why are we suppressing the warning instead of
addressing it, as Andy attempts to do in
https://lkml.kernel.org/r/20251208141618.2805983-1-andriy.shevchenko@xxxxxxxxxxxxxxx?

I went off and looked at the commit which did this to va_format() but
it didn't tell me.