Re: [PATCH] arm64: dts: qcom: sdm845-tama: Keep labibb on, so kernel can disable it

[David Heidelberg]

On 02/12/2025 13:55, Konrad Dybcio wrote:
> On 12/2/25 12:31 PM, David Heidelberg via B4 Relay wrote:
> > From: David Heidelberg <david@xxxxxxx>
> >
> > In case if they were enabled by the bootloader as part of some
> > reference/common routine and left hanging. Linux will switch them off if
> > they're never used.
> >
> > Discussion about it can be found here:
> >    https://lore.kernel.org/all/20251130-oneplus-labibb-v1-1-bb3653e43120@xxxxxxx/
> >
> > Fixes: 5dcc6587fde2 ("arm64: dts: qcom: sdm845-tama: Add display nodes")
> > Suggested-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > Signed-off-by: David Heidelberg <david@xxxxxxx>
> > ---
>
> Perhaps "keeping it on" is a little bit unfortunate in that the wording
> collides with keeping the regulator's output enabled, but anyway
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

So, friend fixed tama-akatsuki against -next tree and having labibb 
nodes there crashes the kernel, so it seems disabling labibb had some 
reason.

So, please do not merge until figured out!

David

> Konrad

--
David Heidelberg