Re: [PATCH 2/2] spi: cadence-quadspi: Fix clock disable on probe failure path

[Nishanth Menon]

On 17:44-20251212, Mark Brown wrote:
> On Fri, Dec 12, 2025 at 12:53:12PM +0530, Anurag Dutta wrote:
> > When cqspi_request_mmap_dma() returns -EPROBE_DEFER after runtime PM
> > is enabled, the error path calls clk_disable_unprepare() on an already
> > disabled clock, causing an imbalance.
> > 
> > Use pm_runtime_get_sync() to increment the usage counter and resume the
> > device. This prevents runtime_suspend() from being invoked and causing
> > a double clock disable.
> 
> Thanks - this is working for me with a hack to trigger the issue,
> hopefully others seeing the issue in real scenarios can confirm.

This seems to fix the warnings I had reported at least.

gist: https://gist.github.com/nmenon/f062ebcb51f97859e97c9716a27fa494

Tested-by: Nishanth Menon <nm@xxxxxx>


-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
https://ti.com/opensource