Re: [PATCH v2 01/26] drm/bridge: add of_drm_get_bridge()

[Maxime Ripard]

Hi,

On Fri, Nov 28, 2025 at 05:50:11PM +0100, Luca Ceresoli wrote:
> of_drm_find_bridge() does not increment the refcount for the returned
> bridge, but that is required now. However converting it and all its users
> is not realistically doable at once given the large amount of (direct and
> indirect) callers and the complexity of some.
> 
> Solve this issue by creating a new of_drm_get_bridge() function that is
> identical to of_drm_find_bridge() except it takes a reference. Then
> of_drm_find_bridge() will be deprecated to be eventually removed.
> 
> Suggested-by: Maxime Ripard <mripard@xxxxxxxxxx>
> Link: https://lore.kernel.org/dri-devel/20250319-stylish-lime-mongoose-0a18ad@houat/
> Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>

I don't think it's a good name still. It's way too close to
drm_bridge_get it gets confusing. I still believe that
of_drm_find_and_get_bridge() is a better name. If you disagree, please
explain why.

Maxime

Attachment: signature.asc
Description: PGP signature