Re: [PATCH v9 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board

[tessolveupstream]

On 05-12-2025 16:22, Konrad Dybcio wrote:
> On 12/1/25 6:22 PM, Sudarshan Shetty wrote:
>> Add the device tree for the QCS615-based Talos EVK platform. The
>> platform is composed of a System-on-Module following the SMARC
>> standard, and a Carrier Board.
> 
> [...]
> 
>> +	hdmi-out {
> 
> You must refer to existing nodes by &label references - let's call
> this one hdmi_connector: hdmi-out {}
> 

Okay, will update in v10 patch.
> [...]
> 
>> +&i2c1 {
>> +	clock-frequency = <400000>;
>> +
>> +	status = "okay";
>> +
>> +	bridge@3d {
>> +		status = "disabled";
>> +	};
> 
> Similarly here - hdmi_bridge: bridge@3d {}
> 

Okay.
>> +
>> +	bridge: bridge@2c {
> 
> lvds_bridge:
>

Okay, got it. > [...]
> 
> +
>> +				sn65dsi84_in: endpoint {
>> +				data-lanes = <0 1 2 3>;
>> +				remote-endpoint = <&mdss_dsi0_out>;
> 
> The formatting fell apart a little here - please give it a touch-up
>

Okay, will update in v10 patch.
> [...]
> >> +&tlmm {
>> +	pcie_default_state: pcie-default-state {
>> +		clkreq-pins {
>> +			pins = "gpio90";
>> +			function = "pcie_clk_req";
>> +			drive-strength = <2>;
>> +			bias-pull-up;
>> +		};
>> +
>> +		perst-pins {
>> +			pins = "gpio101";
>> +			function = "gpio";
>> +			drive-strength = <2>;
>> +			bias-pull-down;
> 
> bias-disable - this pin is active-low
> 

Okay, got it. Will update in next patch
> [...]
> 
>> +&i2c1 {
>> +	clock-frequency = <400000>;
>> +	status = "okay";
>> +	bridge: bridge@3d {
> 
> This really needs a \n above

Okay.
>> +		compatible = "adi,adv7535";
>> +		reg = <0x3d>;
>> +		avdd-supply = <&vreg_v1p8_out>;
>> +		dvdd-supply = <&vreg_v1p8_out>;
>> +		pvdd-supply = <&vreg_v1p8_out>;
>> +		a2vdd-supply = <&vreg_v1p8_out>;
>> +		v3p3-supply = <&vreg_v3p3_out>;
>> +		interrupts-extended = <&tlmm 26 IRQ_TYPE_LEVEL_LOW>;
>> +		adi,dsi-lanes = <4>;
>> +		ports {
> 
> And here

Understood, will take care in v10 patch.

> 
> Konrad