Re: [PATCH] NFC: Fix error handling in nfc_genl_dump_targets

From: Krzysztof Kozlowski

Date: Mon Dec 15 2025 - 06:28:47 EST


On 14/12/2025 14:17, Ma Ke wrote:
> nfc_genl_dump_targets() increments the device reference count via
> nfc_get_device() but fails to decrement it properly. nfc_get_device()
> calls class_find_device() which internally calls get_device() to
> increment the reference count. No corresponding put_device() is made
> to decrement the reference count.
>
> Add proper reference count decrementing using nfc_put_device() when
> the dump operation completes or encounters an error, ensuring balanced
> reference counting.
>
> Found by code review.


NAK, you completely ignore reviewers and send the same. That's not
acceptable.

Best regards,
Krzysztof