Re: Re: Re: [PATCH v7 2/3] PCI: eic7700: Add Eswin PCIe host controller driver

[zhangsenchuan]

> > > Subject: Re: [PATCH v7 2/3] PCI: eic7700: Add Eswin PCIe host controller driver
> 
> Please avoid the pointless quote of all the headers (above) if you
> can.  That just clutters the thread.  Also trim context that is not
> relevant.  More hints here: https://subspace.kernel.org/etiquette.html

Okey, thanks.

> 
> > > On Tue, Dec 02, 2025 at 05:04:06PM +0800, zhangsenchuan@xxxxxxxxxxxxxxxxxx wrote:
> > > > From: Senchuan Zhang <zhangsenchuan@xxxxxxxxxxxxxxxxxx>
> > > > 
> > > > Add driver for the Eswin EIC7700 PCIe host controller, which is based on
> > > > the DesignWare PCIe core, IP revision 5.96a. The PCIe Gen.3 controller
> > > > supports a data rate of 8 GT/s and 4 channels, support INTx and MSI
> > > > interrupts.
> 
> > > > +static int eic7700_pcie_probe(struct platform_device *pdev)
> > > > ...
> > > > +	pci->no_pme_handshake = pcie->data->no_pme_handshake;
> > > 
> > > This needs to go in the 3/3 "PCI: dwc: Add no_pme_handshake flag and
> > > skip PME_Turn_Off broadcast" patch because "no_pme_handshake" doesn't
> > > exist yet so this patch doesn't build by itself.
> > 
> > Do I need to adjust the order of the patches?
> > 3/2 "PCI: dwc: Add no_pme_handshake flag and skip PME_Turn_Off broadcast"
> > 3/3 "PCI: eic7700: Add Eswin PCIe host controller driver"
> > 
> > Or merge Patch 2/3 and Patch 3/3?
> 
> I think the best thing would be to leave dw_pcie_suspend_noirq() along
> and implement eic7700_pcie_suspend_noirq() without calling it.
> 
> dw_pcie_suspend_noirq() is already problematic [1], and we don't need
> more complication there.  Even without calling
> dw_pcie_suspend_noirq(), your eic7700_pcie_suspend_noirq() will be
> pretty simple.  Just add a comment about why you don't use
> dw_pcie_suspend_noirq().
> 
> [1] https://lore.kernel.org/linux-pci/20251114213540.GA2335845@bhelgaas/

Thanks for your suggestion. I have sent the V8 patch, and remove
dw_pcie_suspend_noirq/dw_pcie_resume_noirq in the driver file.

Kind regards,
Senchuan Zhang