Re: [PATCH RESEND v2 5/6] drm/sitronix/st7571: split up the driver into a common and an i2c part

[Javier Martinez Canillas]

Marcus Folkesson <marcus.folkesson@xxxxxxxxx> writes:

> Split up the driver to make it possible to add support for hw interfaces
> other than I2C.
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx>
> ---

[...]

> +config DRM_ST7571_I2C
> +	tristate "DRM support for Sitronix ST7567/ST7571 display panels (I2C)"
> +	depends on DRM_ST7571 && I2C
> +	select REGMAP_I2C

I think this should only be "select REGMAP", since you are not using the
REGMAP I2C support but instead have your own regmap write callback (due
the need to I2C_M_IGNORE_NAK).

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat