Re: [PATCH] RDMA/irdma: fix irdma_alloc_ucontext_resp padding

[Geert Uytterhoeven]

Hi Arnd,

On Mon, 8 Dec 2025 at 14:39, Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> A recent modified struct irdma_alloc_ucontext_resp by adding a member
> with implicit padding in front of it, changing the ABI in an
> incompatibible way on all architectures other than m68k, as
> reported by scripts/check-uapi.sh:
>
> ==== ABI differences detected in include/rdma/irdma-abi.h from 1dd7bde2e91c -> HEAD ====
>     [C] 'struct irdma_alloc_ucontext_resp' changed:
>       type size changed from 704 to 640 (in bits)
>       1 data member deletion:
>         '__u8 rsvd3[2]', at offset 640 (in bits) at irdma-abi.h:61:1
>       1 data member insertion:
>         '__u8 revd3[2]', at offset 592 (in bits) at irdma-abi.h:60:1
>
> Change the ABI back to the previous version, by moving the new
> max_hw_srq_quanta member into a naturally aligned location.
>
> Fixes: 563e1feb5f6e ("RDMA/irdma: Add SRQ support")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks for the discussion in Tokyo!

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds