Re: [PATCH v1 2/3] kexec: print out debugging message if required for kexec_load

[Qiang Ma]

在 2025/12/15 08:32, Andrew Morton 写道:
> On Fri, 12 Dec 2025 17:56:48 +0800 Qiang Ma <maqianga@xxxxxxxxxxxxx> wrote:
>
> > The commit a85ee18c7900 ("kexec_file: print out debugging message
> > if required") has added general code printing in kexec_file_load(),
> > but not in kexec_load().
> >
> > As a result, when using '-d' for the kexec_load interface,
> > print nothing in the kernel space.
> That doesn't sound like a thing which "kernel test robot" would detect
> and report.
>
> > Since the segments debugging message has already been printed by the
> > user-space tool kexec-tools, it will not be printed here in the
> > kernel space.
> >
> > And print out type/start/head of kimage and flags to help debug.
> >
> > Signed-off-by: Qiang Ma <maqianga@xxxxxxxxxxxxx>
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202510310332.6XrLe70K-lkp@xxxxxxxxx/
> Oh I see, that's a warning against an earlier version of this patch.
> But this is labelled "v1"!
yes.
> I suggest we remove this Reported-by record.
ok, I'll collect some other suggestions and fix it together in the next 
version.
> > --- a/kernel/kexec.c
> > +++ b/kernel/kexec.c
> > @@ -166,6 +166,9 @@ static int do_kexec_load(unsigned long entry, unsigned long nr_segments,
> >   	if (ret)
> >   		goto out;
> >   
> > +	kexec_dprintk("kexec_load: type:%u, start:0x%lx head:0x%lx flags:0x%lx\n",
> > +		      image->type, image->start, image->head, flags);
> > +
> >   	/* Install the new kernel and uninstall the old */
> >   	image = xchg(dest_image, image);
> Thanks, I'll await reviewer input before proceeding with this series.