Re: [PATCH] ocfs2: Constify struct configfs_item_operations and configfs_group_operations

[Joseph Qi]

On 2025/12/14 18:41, Christophe JAILLET wrote:
> 'struct configfs_item_operations' and 'configfs_group_operations' are not
> modified in this driver.
> 
> Constifying these structures moves some data to a read-only section, so
> increases overall security, especially when the structure holds some
> function pointers.
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>   74011	  19312	   5280	  98603	  1812b	fs/ocfs2/cluster/heartbeat.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>   74171	  19152	   5280	  98603	  1812b	fs/ocfs2/cluster/heartbeat.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Looks fine.
Acked-by: Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>

> ---
> Compile tested only.
> 
> This change is possible since commits f2f36500a63b and f7f78098690d.
> ---
>  fs/ocfs2/cluster/heartbeat.c   | 4 ++--
>  fs/ocfs2/cluster/nodemanager.c | 8 ++++----
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/ocfs2/cluster/heartbeat.c b/fs/ocfs2/cluster/heartbeat.c
> index 724350925aff..8e9cbc334cf4 100644
> --- a/fs/ocfs2/cluster/heartbeat.c
> +++ b/fs/ocfs2/cluster/heartbeat.c
> @@ -1942,7 +1942,7 @@ static struct configfs_attribute *o2hb_region_attrs[] = {
>  	NULL,
>  };
>  
> -static struct configfs_item_operations o2hb_region_item_ops = {
> +static const struct configfs_item_operations o2hb_region_item_ops = {
>  	.release		= o2hb_region_release,
>  };
>  
> @@ -2193,7 +2193,7 @@ static struct configfs_attribute *o2hb_heartbeat_group_attrs[] = {
>  	NULL,
>  };
>  
> -static struct configfs_group_operations o2hb_heartbeat_group_group_ops = {
> +static const struct configfs_group_operations o2hb_heartbeat_group_group_ops = {
>  	.make_item	= o2hb_heartbeat_group_make_item,
>  	.drop_item	= o2hb_heartbeat_group_drop_item,
>  };
> diff --git a/fs/ocfs2/cluster/nodemanager.c b/fs/ocfs2/cluster/nodemanager.c
> index 6bc4e064ace4..c5e83c774d73 100644
> --- a/fs/ocfs2/cluster/nodemanager.c
> +++ b/fs/ocfs2/cluster/nodemanager.c
> @@ -396,7 +396,7 @@ static struct configfs_attribute *o2nm_node_attrs[] = {
>  	NULL,
>  };
>  
> -static struct configfs_item_operations o2nm_node_item_ops = {
> +static const struct configfs_item_operations o2nm_node_item_ops = {
>  	.release		= o2nm_node_release,
>  };
>  
> @@ -638,7 +638,7 @@ static void o2nm_node_group_drop_item(struct config_group *group,
>  	config_item_put(item);
>  }
>  
> -static struct configfs_group_operations o2nm_node_group_group_ops = {
> +static const struct configfs_group_operations o2nm_node_group_group_ops = {
>  	.make_item	= o2nm_node_group_make_item,
>  	.drop_item	= o2nm_node_group_drop_item,
>  };
> @@ -657,7 +657,7 @@ static void o2nm_cluster_release(struct config_item *item)
>  	kfree(cluster);
>  }
>  
> -static struct configfs_item_operations o2nm_cluster_item_ops = {
> +static const struct configfs_item_operations o2nm_cluster_item_ops = {
>  	.release	= o2nm_cluster_release,
>  };
>  
> @@ -741,7 +741,7 @@ static void o2nm_cluster_group_drop_item(struct config_group *group, struct conf
>  	config_item_put(item);
>  }
>  
> -static struct configfs_group_operations o2nm_cluster_group_group_ops = {
> +static const struct configfs_group_operations o2nm_cluster_group_group_ops = {
>  	.make_group	= o2nm_cluster_group_make_group,
>  	.drop_item	= o2nm_cluster_group_drop_item,
>  };