[tip: x86/boot] x86/boot/e820: Clean up __e820__range_add() a bit

From: tip-bot2 for Ingo Molnar

Date: Sun Dec 14 2025 - 03:37:37 EST


The following commit has been merged into the x86/boot branch of tip:

Commit-ID: a4803df3a2b145fd17bc3d4c23c4c12c74951299
Gitweb: https://git.kernel.org/tip/a4803df3a2b145fd17bc3d4c23c4c12c74951299
Author: Ingo Molnar <mingo@xxxxxxxxxx>
AuthorDate: Thu, 15 May 2025 14:05:30 +02:00
Committer: Ingo Molnar <mingo@xxxxxxxxxx>
CommitterDate: Sun, 14 Dec 2025 09:19:39 +01:00

x86/boot/e820: Clean up __e820__range_add() a bit

- Use 'idx' index variable instead of a weird 'x'
- Make the error message E820-specific
- Group the code a bit better

Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Andy Shevchenko <andy@xxxxxxxxxx>
Cc: Arnd Bergmann <arnd@xxxxxxxxxx>
Cc: Borislav Petkov <bp@xxxxxxxxx>
Cc: Juergen Gross <jgross@xxxxxxxx>
Cc: "H . Peter Anvin" <hpa@xxxxxxxxx>
Cc: Kees Cook <keescook@xxxxxxxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Mike Rapoport <rppt@xxxxxxxxxx>
Cc: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: David Woodhouse <dwmw@xxxxxxxxxxxx>
Link: https://patch.msgid.link/20250515120549.2820541-15-mingo@xxxxxxxxxx
---
arch/x86/kernel/e820.c | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c
index 0c3f12f..4340751 100644
--- a/arch/x86/kernel/e820.c
+++ b/arch/x86/kernel/e820.c
@@ -166,17 +166,18 @@ int e820__get_entry_type(u64 start, u64 end)
*/
static void __init __e820__range_add(struct e820_table *table, u64 start, u64 size, enum e820_type type)
{
- int x = table->nr_entries;
+ int idx = table->nr_entries;

- if (x >= ARRAY_SIZE(table->entries)) {
- pr_err("too many entries; ignoring [mem %#010llx-%#010llx]\n",
- start, start + size - 1);
+ if (idx >= ARRAY_SIZE(table->entries)) {
+ pr_err("too many E820 table entries; ignoring [mem %#010llx-%#010llx]\n",
+ start, start + size-1);
return;
}

- table->entries[x].addr = start;
- table->entries[x].size = size;
- table->entries[x].type = type;
+ table->entries[idx].addr = start;
+ table->entries[idx].size = size;
+ table->entries[idx].type = type;
+
table->nr_entries++;
}