Re: [PATCH] xtensa: mmu: validate user access in fast_load_store with MMU

From: Max Filippov

Date: Sun Dec 14 2025 - 02:24:52 EST


On Sat, Dec 13, 2025 at 11:14 PM Max Filippov <jcmvbkbc@xxxxxxxxx> wrote:
> > #ifdef CONFIG_MMU
> > /* l32e can't be used here even when it's available. */
> > - /* TODO access_ok(a3) could be used here */
> > - j .Linvalid_instruction
> > + movi a5, 8
> > + access_ok a3, a5, a0, a2, .Linvalid_instruction
>
> New code should use tabs, not spaces, just like the existing code.

Disregard that, the other version of the patch is formatted with spaces,
this one is good.

Please add patch version if you send multiple versions of the patch.

--
Thanks.
-- Max