Re: [PATCH RFC] soc: qcom: socinfo: Re-implement in Rust
From: Matthew Maurer
Date: Sat Dec 13 2025 - 12:11:40 EST
On Sat, Dec 13, 2025 at 8:26 AM Matthew Maurer <mmaurer@xxxxxxxxxx> wrote:
>
> On Sat, Dec 13, 2025 at 5:28 AM Greg KH <greg@xxxxxxxxx> wrote:
> >
> > On Sat, Dec 13, 2025 at 12:36:00AM +0000, Matthew Maurer wrote:
> > > Re-implements qcom-socinfo driver in Rust, using `Scoped`-based DebugFS
> > > bindings.
> > >
> > > Signed-off-by: Matthew Maurer <mmaurer@xxxxxxxxxx>
> > > ---
> > > This patch converts the QC socinfo driver to Rust, intended to be the
> > > first Rust driver in Android that is owned by a vendor rather than the
> > > platform.
> >
> > Um, shouldn't you have a signed-off-by from the maintainers of the .c
> > file here? You are deleting it, and then not adding anything to the
> > MAINTAINERS file to take ownership of this new file, which I thought
> > checkpatch would have warned about.
>
> Checkpatch did not warn me about this, but I did add the maintainers
> of that file on this RFC, so we can see how they feel about it on this
> thread.
>
Further clarification - checkpatch *did* warn me that perhaps
MAINTAINERS needed updating because files were added or removed, but I
saw that the maintainers were by `drivers/soc/qcom` which should
include all the new files. It did not warn me that I needed any
additional Signed-off-by lines.
> >
> > thanks,
> >
> > greg k-h