Re: [PATCH RFC] soc: qcom: socinfo: Re-implement in Rust
From: Miguel Ojeda
Date: Fri Dec 12 2025 - 22:01:57 EST
On Sat, Dec 13, 2025 at 3:50 AM Bryan O'Donoghue <bod@xxxxxxxxxx> wrote:
>
> One thing I notice is that, in C we alphabetise the includes.
>
> What is the normative coding standard for rust stuff I'm not sure. Is
> there any technical reason not to do the same as C includes alphabetising ?
>
> You appear to sort these kernel:: use statements earlier on in the patch.
They should be sorted, yeah (`rustfmt` takes care of that
automatically). In addition, recently we define the style for imports
(even if not all code follows it yet) -- please see:
https://docs.kernel.org/rust/coding-guidelines.html#imports
Thanks for taking a look, and I hope that clarifies.
Cheers,
Miguel