Re: [PATCH net-next v1 1/3] dt-bindings: net: micrel: Convert to YAML schema
From: Stefan Eichenberger
Date: Fri Dec 12 2025 - 09:52:01 EST
On Fri, Dec 12, 2025 at 04:29:50AM -0600, Rob Herring (Arm) wrote:
>
> On Fri, 12 Dec 2025 09:46:16 +0100, Stefan Eichenberger wrote:
> > From: Stefan Eichenberger <stefan.eichenberger@xxxxxxxxxxx>
> >
> > Convert the devicetree bindings for the Micrel PHY to YAML schema. This
> > also combines the information from micrel.txt and micrel-ksz90x1.txt
> > into a single micrel.yaml file as this PHYs are from the same series.
> > Use yaml conditions to differentiate the properties that only apply to
> > specific PHY models.
> >
> > Signed-off-by: Stefan Eichenberger <stefan.eichenberger@xxxxxxxxxxx>
> > ---
> > .../bindings/net/micrel-ksz90x1.txt | 228 --------
> > .../devicetree/bindings/net/micrel.txt | 57 --
> > .../devicetree/bindings/net/micrel.yaml | 527 ++++++++++++++++++
> > 3 files changed, 527 insertions(+), 285 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
> > delete mode 100644 Documentation/devicetree/bindings/net/micrel.txt
> > create mode 100644 Documentation/devicetree/bindings/net/micrel.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/net/micrel.yaml:504:1: [warning] too many blank lines (2 > 1) (empty-lines)
>
> dtschema/dtc warnings/errors:
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.kernel.org/project/devicetree/patch/20251212084657.29239-2-eichest@xxxxxxxxx
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
Thanks for the finding, I will fix it in the next version. Somehow, my
linter doesn't catch that even if I run it manually, sorry about that.
Regards,
Stefan