Re: [PATCH v8 0/2] iio: Add support for TI ADS1X18 ADCs
From: Tomas Melin
Date: Fri Dec 12 2025 - 08:50:47 EST
On 12/12/2025 15:10, Kurt Borja wrote:
> On Fri Dec 12, 2025 at 3:40 AM -05, Tomas Melin wrote:
>> Hi,
>>
>> Sorry for coming in late in the cycle, can you please explain why the
>> driver for ADS1015 could not be extended to support also ADS1x18
>> devices? Briefly looking into the topic, they seem to be very closely
>> related.
>>
>> Have You looked into that alternative?
>
> Yes, this was discussed in v1.
>
> Although they are related, these two devices do not use the same
> protocol and regmap is not a good fit for ADS1X18. We need two different
> SPI message structure for driving the two operating modes (direct,
> buffer) and the trigger needs some special considerations because
> ads1x18 share their drdy interrupt line with the MOSI pin.
>
> We concluded merging the two drivers would be too messy as both
> protocols would need a lot of unique code. Not to mention different
> triggers, buffers, custom callbacks, etc.
This information would be really valuable to put into the cover letter.
Thanks,
Tomas
>
>>
>> Thanks,
>> Tomas
>