Re: [PATCH] PCI: Remove redundant pci_dev_unlock() in pci_slot_trylock()

[Jinhui Guo]

On Thu, Dec 11, 2025 20:13:59 +0200, Ilpo Järvinen wrote:
> > Commit a4e772898f8b ("PCI: Add missing bridge lock to pci_bus_lock()")
> > delegates the bridge device's pci_dev_trylock() to pci_bus_trylock()
> > in pci_slot_trylock(), but it leaves a redundant pci_dev_unlock() when
> > pci_bus_trylock() fails.
> > 
> > Remove the redundant bridge-device pci_dev_unlock() in pci_slot_trylock(),
> > since that lock is no longer taken there.
> 
> Doesn't it cause issues if trying to unlock something that wasn't locked 
> so saying its "redundant" seem a bit an understatement?

Hi, Ilpo Järvinen

Thanks for your time. The commit message was a bit brief, so I've sent v2
https://lore.kernel.org/all/20251212133737.2367-1-guojinhui.liam@xxxxxxxxxxxxx/
with more details.

Best Regards,
Jinhui