Re: [PATCH 1/4] dt-bindings: pwm: sunxi: add PWM controller for Allwinner H616

[Richard GENOUD]

Le 12/12/2025 à 09:25, Krzysztof Kozlowski a écrit :
> On 12/12/2025 08:50, Richard GENOUD wrote:
> > > > +
> > > > +  clocks:
> > > > +    items:
> > > > +      - description: Bus Clock
> > > > +
> > >
> > > Are you sure there is no first clock? Really, really sure? If you add it
> > > later, I would be pretty sad, because that's unnecessary duplication of
> > > binidngs....
> > I surely don't want to make you sad :)
> >
> > Having a second look at the sun4i binding, I think there's a way to use it.
> > The sun4i, as you said, has a module clock (OSC24M) and an optional bus
> > clock.
> > Here, the bus clock is mandatory, but the H616 PWM uses OSC24M and APB1
> > as clock sources.
> >
> > So, I guess that if we add something like that:
> >      clocks:
> >        minItems: 1
> >        items:
> >          - description: Module Clock
> >          - description: Bus Clock
> > +      - description: APB Clock
> >
> >      clock-names:
> >        minItems: 1
> >        items:
> >          - const: mod
> >          - const: bus
> > +      - const: apb
> >
> >      resets:
> >        maxItems: 1
> >
> > In the sun4i pwm binding, we could re-use it for the H616 pwm right?
> > (APB clock is maybe not the best name, could be secondary module clock)
>
>
> apb is probably the bus clock, so you don't need to change the bindings
> at all.
Indeed, your're right!
So the only difference will the the #clock-cells for h616.
I'll send a v2 using the sun4i binding.

Thanks!

Regards,
Richard

> Best regards,
> Krzysztof


--
Richard Genoud, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com