Re: [PATCH v5 1/4] LoongArch: Add SCQ support detection

[Huacai Chen]

On Fri, Dec 12, 2025 at 12:12 PM Xi Ruoyao <xry111@xxxxxxxxxxx> wrote:
>
> On Fri, 2025-12-12 at 11:55 +0800, George Guo wrote:
>
> > diff --git a/arch/loongarch/kernel/cpu-probe.c b/arch/loongarch/kernel/cpu-probe.c
> > index a2060a24b39fd78fa255816fa5518e0ee99b8a8e..47815a55b7b48bbffd4954a9b8bdf7021d7e234d 100644
> > --- a/arch/loongarch/kernel/cpu-probe.c
> > +++ b/arch/loongarch/kernel/cpu-probe.c
> > @@ -201,6 +201,10 @@ static void cpu_probe_common(struct cpuinfo_loongarch *c)
> >               c->options |= LOONGARCH_CPU_PTW;
> >               elf_hwcap |= HWCAP_LOONGARCH_PTW;
> >       }
> > +     if (config & CPUCFG2_SCQ)
> > +             c->options |= LOONGARCH_CPU_SCQ;
> > +     else
> > +             pr_warn_once("CPU does NOT support SCQ\n");
>
> IMO this should be a pr_info_once.  CPU lacks SCQ is not anything wrong
> thus this shouldn't be a warning.
IMO we don't need any print, and maybe we can be put in hwcap?

Huacai

>
> >       if (config & CPUCFG2_LSPW) {
> >               c->options |= LOONGARCH_CPU_LSPW;
> >               elf_hwcap |= HWCAP_LOONGARCH_LSPW;
>
> --
> Xi Ruoyao <xry111@xxxxxxxxxxx>