Re: linux-next: build failure after merge of the mailbox tree

[Jason-JH Lin (林睿祥)]

On Wed, 2025-12-10 at 18:01 -0600, Jassi Brar wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Wed, Dec 10, 2025 at 5:49 PM Stephen Rothwell
> <sfr@xxxxxxxxxxxxxxxx> wrote:
> > 
> > Hi all,
> > 
> > After merging the mailbox tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c: In function
> > 'mdp_probe':
> > drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c:311:41: error:
> > implicit declaration of function 'cmdq_get_shift_pa' [-Wimplicit-
> > function-declaration]
> >   311 |                 mdp->cmdq_shift_pa[i] =
> > cmdq_get_shift_pa(mdp->cmdq_clt[i]->chan);
> >       |                                         ^~~~~~~~~~~~~~~~~
> > 
> > Caused by commit
> > 
> >   e1fe978a07c7 ("mailbox: mtk-cmdq: Remove unsued
> > cmdq_get_shift_pa()")
> > 

Hi Jassi,

> Jason, isn't your "Remove shift_pa from CMDQ jump functions" patchset
> picked already?

No, soc, drm and mdp3 maintainers have not picked the patches before
this patch.

> Ideally this patch should have gone in that patchset. But if that pr
> will be merged soon, maybe I can hold off mine. Otherwise, I will
> drop
> this patch.

Please apply this patch, after all previous series have been applied in
order.
Series application order:
1. [Fixes] Refine DMA address handling for the command buffer
https://lore.kernel.org/all/20251022171847.379470-1-jason-jh.lin@xxxxxxxxxxxx/
2. [Series 1/4] Add GCE support for MT8196 and update CMDQ APIs
https://lore.kernel.org/all/20251031155838.1650833-1-jason-jh.lin@xxxxxxxxxxxx/
3. [Series 2/4] Migrate subsystems to new CMDQ APIs
https://lore.kernel.org/all/20251031160309.1654761-1-jason-jh.lin@xxxxxxxxxxxx/
4. [Series 3/4] Remove shift_pa from CMDQ jump functions
https://lore.kernel.org/all/20251031160712.1657810-1-jason-jh.lin@xxxxxxxxxxxx/
5. [Series 4/4] Remove deprecated CMDQ APIs (***this patch's series***)

Thanks!

---

Hi Angelo, CK, Nicolas,

Can you help to apply the patches before this one and send the pull
request soon?
Or are we plan to apply them later and drop this patch for now?

Regards,
Jason-JH.Lin

> 
> thanks
> -Jassi