Re: [PATCH v1 1/1] ASoC: Fix acronym for Intel Gemini Lake

[Bjorn Helgaas]

On Thu, Dec 11, 2025 at 03:32:04PM +0200, Andy Shevchenko wrote:
> On Thu, Dec 11, 2025 at 09:45:54AM +0100, Cezary Rojewski wrote:
> > On 2025-12-10 12:55 PM, Andy Shevchenko wrote:
> > > While the used GML is consistent with the pattern for other Intel * Lake
> > > SoCs, the de facto use is GLK. Update the acronym and users accordingly.

> > > -#define PCI_DEVICE_ID_INTEL_HDA_GML	0x3198
> > > +#define PCI_DEVICE_ID_INTEL_HDA_GLK	0x3198
> > 
> > If two #defines are no-go (PCI_DEVICE_ID_INTEL_HDA_GLK and _GML), then
> > perhaps at least a comment to the right of the ID mentioning the "GML" would
> > help.
> 
> Bjorn, are you agree on adding a comment to PCI IDs to point out that in a
> couple of Intel documents the machine's acronym is GML?

Sure, that would be fine.