Re: [PATCH v3 2/3] gpu: nova-core: select RUST_FW_LOADER_ABSTRACTIONS

[Alexandre Courbot]

On Mon Dec 15, 2025 at 11:59 PM JST, Alyssa Ross wrote:
> On Thu, Nov 06, 2025 at 11:40:55AM +0900, Alexandre Courbot wrote:
>> RUST_FW_LOADER_ABSTRACTIONS was depended on by NOVA_CORE, but NOVA_CORE
>> is selected by DRM_NOVA. This creates a situation where, if DRM_NOVA is
>> selected, NOVA_CORE gets enabled but not RUST_FW_LOADER_ABSTRACTIONS,
>> which results in a build error.
>>
>> Since the firmware loader is an implementation detail of the driver, it
>> should be enabled along with it, so change the "depends on" to a
>> "select".
>>
>> Fixes: 54e6baf123fd ("gpu: nova-core: add initial driver stub")
>> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
>> ---
>
> I just encountered this testing 6.19-rc1, and was pleased to discover
> this patch had already been submitted.
>
> Tested-by: Alyssa Ross <hi@xxxxxxxxx>
>
> And it probably also makes sense to add this now that the kernel test
> robot has also found it:
>
> Closes: https://lore.kernel.org/oe-kbuild-all/202512061721.rxKGnt5q-lkp@xxxxxxxxx/

Thanks! Both tags added.

>
> (I suppose it doesn't make sense to add the Reported-by suggested there
> since your patch predates that report.)
>
> I see that the first patch from this series has already been picked up
> by Greg, but this and patch 3 are still waiting.  Is that correct?

After rebasing on top of -rc1, I can confirm. This patch is going to be
taken through the Nova tree. Patch 3 is available for the relevant
maintainers to take.