Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Fix interrupt controller node name

From: Kunihiko Hayashi

Date: Tue Dec 16 2025 - 00:59:34 EST


On 2025/12/16 11:18, Rob Herring wrote:
On Mon, Dec 15, 2025 at 7:21 PM Kunihiko Hayashi
<hayashi.kunihiko@xxxxxxxxxxxxx> wrote:

Hi Rob,

Thank you for pointing out.

On 2025/12/16 6:24, Rob Herring (Arm) wrote:
The child node name in use by .dts files and the driver is
"legacy-interrupt-controller", not "interrupt-controller".
After your change commit bcd7ec2cd720 were merged, it was a long time
before I realized I needed to fix it.

"interrupt-controller" is included in the list of Generic Names
Recommendation. Would it be better to apply (i.e. restore) this,
or fix the PCI driver and .dts?

It's an ABI. So we are stuck with it or have to support both names in
the driver forever (and backport the driver change).

I understand.
If allowing "interrupt-controller", should allow both names in the
driver and bindings.

At this time, it's preferable to align the bindings definition to
remove mismatch warnings.

Reviewed-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>

Thank you,

---
Best Regards
Kunihiko Hayashi