Re: [PATCH v1] mtd: sm_ftl: use strscpy() in sm_attr_show()

[Miquel Raynal]

Hello,

On 06/12/2025 at 03:53:13 GMT, Dharanitharan R <dharanitharan725@xxxxxxxxx> wrote:

> In sm_ftl.c, the sm_attr_show() function currently copies
> attribute data using:
>
>     strncpy(buf, sm_attr->data, sm_attr->len);
>     return sm_attr->len;
>
> Using strncpy() can be unsafe because it does not guarantee
> a NUL terminator if the source length equals the buffer size.
> Although sm_attr->data comes from internal structures and
> is NUL-terminated, it is cleaner and safer to use strscpy(),
> which guarantees NUL termination and avoids zero-padding.
>
> The destination buffer is PAGE_SIZE bytes, which is sufficient
> to hold sm_attr->data without truncation. The return value
> of strscpy() matches the expected behavior of sm_attr_show().
>
> Replace the strncpy() call with:
>
>     return strscpy(buf, sm_attr->data, PAGE_SIZE);
>
> Signed-off-by: Dharanitharan R <dharanitharan725@xxxxxxxxx>

This commit won't apply, please resend based on v6.19-rc1.

Thanks,
Miquèl