Re: [PATCH v2 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update

[Krishna Kurapati]

On 12/9/2025 10:06 AM, Krishna Kurapati wrote:
> On 12/6/2025 4:32 PM, Krzysztof Kozlowski wrote:
> > On Fri, Dec 05, 2025 at 10:55:36PM +0200, Dmitry Baryshkov wrote:
> > > On Thu, Dec 04, 2025 at 10:16:42AM +0530, Krishna Kurapati wrote:
> > > > Add squelch detect parameter update for synopsys eusb2 repeater.
> > > >
> > > > Signed-off-by: Krishna Kurapati <krishna.kurapati@xxxxxxxxxxxxxxxx>
> > > > ---
> > > >   .../devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 8 ++++ 
> > > > ++++
> > > >   1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2- 
> > > > repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps- 
> > > > eusb2-repeater.yaml
> > > > index 5bf0d6c9c025..f2afcf0e986a 100644
> > > > --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2- 
> > > > repeater.yaml
> > > > +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2- 
> > > > repeater.yaml
> > > > @@ -59,6 +59,14 @@ properties:
> > > >       minimum: 0
> > > >       maximum: 7
> > > > +  qcom,squelch-detector-bp:
> > >
> > > -uV? -mV?
> >
> > If thi sis adjustment in ratio, then bp is correct. Some sort of
> > explanation in commit msg would be nice, but I don't want to stall the
> > patchset for that.
> >
> > Assuming this is indeed ratio without actual SI units:
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>
> Thanks for the RB Krzysztof,
>
>   Can I update the following as commit text and retain your RB when 
> sending v3:
>
> "Add squelch detect parameter update for synopsys eusb2 repeater. The
> values (indicated in basis-points) depict a percentage change with
> respect to the nominal value."

Hi Krzysztof,

 Can you help let me know if the above commit message can be added with 
retaining your RB tag.

Regards,
Krishna,