Re: [RFC 06/12] bio: don't check target->bi_status on error
From: Andreas Gruenbacher
Date: Tue Dec 16 2025 - 03:45:51 EST
On Tue, Dec 16, 2025 at 8:59 AM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Mon, Dec 08, 2025 at 12:10:13PM +0000, Andreas Gruenbacher wrote:
> > In a few places, target->bi_status is set to source->bi_status only if
> > source->bi_status is not 0 and target->bi_status is (still) 0. Here,
> > checking the value of target->bi_status before setting it is an
> > unnecessary micro optimization because we are already on an error path.
>
> What is source and target here? I have a hard time trying to follow
> what this is trying to do.
Not sure, what would you suggest instead?
Thanks,
Andreas