Re: [PATCH 1/1] scsi: ufs: core: Fix error handler encryption support
From: Christoph Hellwig
Date: Tue Dec 16 2025 - 05:45:50 EST
On Mon, Dec 15, 2025 at 08:47:03AM -0800, Bart Van Assche wrote:
> > I don't think callers vs calle is the important part here. It is to
> > check if any actual data is tranferred instead of special casing EH
> > commands.
>
> Hi Christoph,
>
> Do you agree with the following?
>
> (a) There is code in the SCSI error handler that submits SCSI commands
> with a data buffer. Hence, disabling encryption if and only if the
> data buffer length is zero can't fix the reported problem. From
> scsi_eh_prep_cmnd() in drivers/scsi/scsi_error.c:
This still does not actually transfer data to the media, and thus
is not affected by inline encryption.