RE: [PATCH net-next v4 1/7] net: axienet: Fix resource release ordering

[Gupta, Suraj]

[Public]

Hi,
> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Wednesday, August 6, 2025 2:29 AM
> To: Sean Anderson <sean.anderson@xxxxxxxxx>
> Cc: Pandey, Radhey Shyam <radhey.shyam.pandey@xxxxxxx>; Andrew Lunn
> <andrew+netdev@xxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; Simek, Michal <michal.simek@xxxxxxx>;
> Leon Romanovsky <leon@xxxxxxxxxx>; Gupta, Suraj <Suraj.Gupta2@xxxxxxx>
> Subject: Re: [PATCH net-next v4 1/7] net: axienet: Fix resource release ordering
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> > +static void axienet_disable_misc(void *clocks) {
> > +     clk_bulk_disable_unprepare(XAE_NUM_MISC_CLOCKS, clocks); }
> > +
>
> ...
>
> >       ret = devm_clk_bulk_get_optional(&pdev->dev, XAE_NUM_MISC_CLOCKS,
> lp->misc_clks);
> >       if (ret)
> > -             goto cleanup_clk;
> > +             return dev_err_probe(&pdev->dev, ret,
> > +                                  "could not get misc. clocks\n");
> >
> >       ret = clk_bulk_prepare_enable(XAE_NUM_MISC_CLOCKS, lp->misc_clks);
> >       if (ret)
> > -             goto cleanup_clk;
> > +             return dev_err_probe(&pdev->dev, ret,
> > +                                  "could not enable misc. clocks\n");
> > +
> > +     ret = devm_add_action_or_reset(&pdev->dev, axienet_disable_misc,
> > +                                    lp->misc_clks);
>
> It seems like it would be better to add
> devm_clk_bulk_get_optional_enable(). There is already an
> devm_clk_bulk_get_all_enabled() so it does not seem like too big a step.
>
>         Andrew

We are interested in this patch to fix AXI Ethernet probe path and can collaborate on upstreaming it.

Regards,
Suraj