Re: [PATCH v2 2/4] irqchip: add RZ/{T2H,N2H} Interrupt Controller (ICU) driver

[Geert Uytterhoeven]

Hi Cosmin,

On Mon, 1 Dec 2025 at 12:30, Cosmin Tanislav
<cosmin-gabriel.tanislav.xa@xxxxxxxxxxx> wrote:
> The Renesas RZ/T2H (R9A09G077) and Renesas RZ/N2H (R9A09G087) SoCs have
> an Interrupt Controller (ICU) that supports interrupts from external
> pins IRQ0 to IRQ15, and SEI, and software-triggered interrupts INTCPU0
> to INTCPU15.
>
> INTCPU0 to INTCPU13, IRQ0 to IRQ13 are non-safety interrupts, while
> INTCPU14, INTCPU15, IRQ14, IRQ15 and SEI are safety interrupts, and are
> exposed via a separate register space.
>
> Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@xxxxxxxxxxx>

Thanks for your patch, which is now commit 13e7b3305b647cf5
("irqchip: Add RZ/{T2H,N2H} Interrupt Controller (ICU) driver")
in irqchip/irq/drivers.

> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -423,6 +423,7 @@ config ARCH_R9A09G057
>  config ARCH_R9A09G077
>         bool "ARM64 Platform support for R9A09G077 (RZ/T2H)"
>         default y if ARCH_RENESAS
> +       select RENESAS_RZT2H_ICU
>         help
>           This enables support for the Renesas RZ/T2H SoC variants.
>

This change should have been a separate patch, to be routed through the
renesas-devel tree.  In addition, you forgot to add the same select to the
ARCH_R9A09G087 entry below.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds