Re: [PATCH v3 0/4] gpu: nova-core: fixups for GSP message queue and bindings

From: Alexandre Courbot

Date: Tue Dec 16 2025 - 09:49:01 EST


On Tue Dec 16, 2025 at 11:57 AM JST, Alexandre Courbot wrote:
> This series contains a few fixups for the recently merged GSP
> command-queue code, by order of importance:
>
> - Some explicit padding required to safely implement `AsBytes` was
> missing in the bindings,
> - A bug in the received message length calculation results in the
> message handler being given more data than it should,
> - `MaybeZeroable` is now derived by the kernel's bindgen, but the Nova
> bindings have not been updated for that,
> - Some items in the bindings were referred to using the version module
> directly, instead of the alias we defined to limit the diff when we
> upgrade firmware versions.
>
> All of them address "bugs" (with the first two fixing actual correctness
> issues), but since Nova does not do much anyway, they are also not
> absolutely critical. Other series planned for this cycle will depend on
> them, so one way or the other it would be great to see them in
> drm-rust-next.
>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>

Pushed (with Danilo's Acked-by received on Zulip) to drm-rust-fixes,
thanks!

["gpu: nova-core: gsp: fix length of received messages":
update `PANIC:` comments as pointed out by Joel.]