Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf()
From: Brendan Jackman
Date: Tue Dec 16 2025 - 12:10:53 EST
On Tue, 16 Dec 2025 at 13:36, David Laight <david.laight.linux@xxxxxxxxx> wrote:
>
> On Tue, 16 Dec 2025 09:16:41 +0000
> Brendan Jackman <jackmanb@xxxxxxxxxx> wrote:
>
> ...
> > Given the kernel is usually W=1 clean, it seems like we _do_ support it.
> > It's just that we support it via these akwkward retroactive fixups
> > instead of just expecting code to be W=1-clean before we merge it?
>
> It's not that W=1 clean, the bot remembers which warnings it has seen and
> only reports new ones.
I haven't been doing it for long, but I build with W=1 in Github
Actions [0] and this suggest-attribute-format is the first issue
that's come up there. I don't have any logic to exclude pre-existing
errors.
I am only building a pretty small config there (enough to run a few
selftests on QEMU) but it does suggest that people "support" W=1 at
least for the core kernel code.
[0] https://github.com/bjackman/limmat-kernel-nix