Re: [PATCH net v4 0/4] net: dsa: lantiq: a bunch of fixes

From: Vladimir Oltean
Date: Tue Dec 16 2025 - 13:23:22 EST


On Tue, Dec 16, 2025 at 06:08:06PM +0000, Daniel Golle wrote:
> On Wed, Dec 10, 2025 at 06:16:33PM +0200, Vladimir Oltean wrote:
> > On Tue, Dec 09, 2025 at 01:27:42AM +0000, Daniel Golle wrote:
> > > This series is the continuation and result of comments received for a fix
> > > for the SGMII restart-an bit not actually being self-clearing, which was
> > > reported by by Rasmus Villemoes.
> > >
> > > A closer investigation and testing the .remove and the .shutdown paths
> > > of the mxl-gsw1xx.c and lantiq_gswip.c drivers has revealed a couple of
> > > existing problems, which are also addressed in this series.
> > >
> > > Daniel Golle (4):
> > > net: dsa: lantiq_gswip: fix order in .remove operation
> > > net: dsa: mxl-gsw1xx: fix order in .remove operation
> > > net: dsa: mxl-gsw1xx: fix .shutdown driver operation
> > > net: dsa: mxl-gsw1xx: manually clear RANEG bit
> > >
> > > drivers/net/dsa/lantiq/lantiq_gswip.c | 3 --
> > > drivers/net/dsa/lantiq/lantiq_gswip.h | 2 --
> > > drivers/net/dsa/lantiq/lantiq_gswip_common.c | 19 +++++-----
> > > drivers/net/dsa/lantiq/mxl-gsw1xx.c | 38 +++++++++++++++++---
> > > 4 files changed, 44 insertions(+), 18 deletions(-)
> > >
> > > --
> > > 2.52.0
> >
> > From a DSA API perspective this seems fine.
> > Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx>
> >
>
> In case you are reluctant to accept patch 4/4 ("net: dsa: mxl-gsw1xx:
> manually clear RANEG bit") it'd be nice to have at least patch 1, 2 and
> 3 merged as-is, and I'll resend 4/4 as a single patch being a simple
> msleep(10) instead of the delayed_work approach, if that's the reason
> for the series not being accepted.

I think it has more to do with the fact that network maintainers are
taking a well deserved end of year break.
https://lore.kernel.org/netdev/15b104e5-7e8d-4a7c-a500-5632a4f3f9a8@xxxxxxxxxx/

There are older patches than yours in patchwork.