Re: [PATCH 3/3] mm/khugepaged: make khugepaged_collapse_control static

From: Wei Yang
Date: Tue Dec 16 2025 - 21:48:58 EST


On Tue, Dec 16, 2025 at 11:11:42AM +0000, Shivank Garg wrote:
>The global variable 'khugepaged_collapse_control' is not used outside of
>mm/khugepaged.c. Make it static to limit its scope.
>
>Signed-off-by: Shivank Garg <shivankg@xxxxxxx>

Reviewed-by: Wei Yang <richard.weiyang@xxxxxxxxx>

>---
> mm/khugepaged.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/khugepaged.c b/mm/khugepaged.c
>index 65b1b778378a..d130357a2d88 100644
>--- a/mm/khugepaged.c
>+++ b/mm/khugepaged.c
>@@ -829,7 +829,7 @@ static void khugepaged_alloc_sleep(void)
> remove_wait_queue(&khugepaged_wait, &wait);
> }
>
>-struct collapse_control khugepaged_collapse_control = {
>+static struct collapse_control khugepaged_collapse_control = {
> .is_khugepaged = true,
> };
>
>--
>2.43.0
>

--
Wei Yang
Help you, Help me