RE: [PATCH v3 4/5] pinctrl: samsung: fold GS101 pin-bank macros into EXYNOS9_*
From: Alim Akhtar
Date: Tue Dec 16 2025 - 23:43:40 EST
Hi Youngmin
> -----Original Message-----
> From: Youngmin Nam <youngmin.nam@xxxxxxxxxxx>
> Sent: Tuesday, December 2, 2025 3:06 PM
> To: krzk@xxxxxxxxxx; s.nawrocki@xxxxxxxxxxx; alim.akhtar@xxxxxxxxxxx;
> linus.walleij@xxxxxxxxxx; peter.griffin@xxxxxxxxxx;
> semen.protsenko@xxxxxxxxxx; ivo.ivanov.ivanov1@xxxxxxxxx
> Cc: ryu.real@xxxxxxxxxxx; d7271.choe@xxxxxxxxxxx;
> shin.son@xxxxxxxxxxx; jaewon02.kim@xxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx; linux-
> gpio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Youngmin Nam
> <youngmin.nam@xxxxxxxxxxx>
> Subject: [PATCH v3 4/5] pinctrl: samsung: fold GS101 pin-bank macros into
> EXYNOS9_*
>
> GS101 had dedicated GS101_PIN_BANK_EINT{G,W} helpers, but they are
> redundant with EXYNOS9_PIN_BANK_EINT{G,W} (same semantics, including
> the per-bank .eint_fltcon_offset).
> This change removes the GS101_* macros and switches the GS101 pin-bank
> tables to the EXYNOS9_* helpers with exynos9_bank_type_{alive,off}.
> While here, update the struct comment to note FLTCON is Exynos9-specific
> (not 'GS101-specific').
>
> One macro family for all Exynos9-era SoCs (incl. GS101) reduces copy-paste
> drift and keeps the FLTCON handling consistent.
> There is no functional change.
>
> Signed-off-by: Youngmin Nam <youngmin.nam@xxxxxxxxxxx>
> Reviewed-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
> Reviewed-by: Peter Griffin <peter.griffin@xxxxxxxxxx>
> Tested-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx>
> Tested-by: Peter Griffin <peter.griffin@xxxxxxxxxx> (tested on Pixel6/gs101)
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
Tested this series on Exynosautov920 sadk board
Tested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>