Re: [PATCH v2 2/4] dt-bindings: media: i2c: et8ek8: document missing crc as optional property

From: Krzysztof Kozlowski

Date: Wed Dec 17 2025 - 03:34:12 EST


On Sun, Dec 14, 2025 at 11:58:33PM -0800, Alex Tran wrote:
> Convert the et8ek8 sensor device tree binding from TXT to YAML format.

Commit subject is completely wrong. You are not documenting missing
properties.

> Add the optional crc property to the endpoint node for the et8ek8 sensor.

Why?

> This property enables CRC checksums for the sensor bus and was added to
> match the new driver support for reading it from the device tree.

This does not explain me why.

I asked you first to convert the bindings, not add new properties. If
you add new properties, you must provide justification why binding has
to be changed - see other commits how to do this. Also please read
submitting patches how to split your work into logical chunks.

Best regards,
Krzysztof