Re: [PATCH] regulator: qcom_smd: change MP5496 supply names

[Konrad Dybcio]

On 12/16/25 7:38 PM, Gabor Juhos wrote:
> In case of the MP5496 regulators, the driver uses the same name both for
> the regulator and for its supply. Due to this, in some cases the supply
> gets resolved to the regulator itself, and the regulator core code throwns
> an error message.
> 
> For example, booting the kernel with the 'ipq9574-rdp433' device tree,
> results in the following message in the log:
> 
>   [    1.710392] qcom_rpm_smd_regulator remoteproc:glink-edge:rpm-requests:regulators: Supply for s1 (s1) resolved to itself
> 
> Additionally, the driver uses different supply names for the 's2' and for
> the 'l2' regulators which is incorrect. Here is the supply map based on the
> datasheet of the MP5496:
> 
>   VIN1 -> Buck1
>   VIN2 -> Buck2, LDO2, LDO3
>   VIN3 -> Buck3
>   VIN4 -> Buck4
>   VIN5 -> LDO4, LDO5

One thing this reveals is that there's an LDO3 and an LDO4 which
we don't describe today.. are they managed as power-domains, or
are there other other reasons?

Konrad